add local directory support #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeff Widman <[email protected]>
Co-authored-by: Jeff Widman <[email protected]>
brrygrdn
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Thanks for this, it makes a ton of sense.
I'm 👍🏻 on --local as the flag as we don't really have any other context other than local-dir right now, running against a local-host ( e.g. GHES? ) seems way out of scope and I think it can be achieved via the job definition if we needed to in a pinch.
# Conflicts: # cmd/dependabot/internal/cmd/update.go # cmd/dependabot/internal/cmd/update_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to copy a local directory into the updater to be used as the repository to be updated. The file fetcher will prefer to use the locally cloned repository and won't hit GitHub to fetch the files.
Copying in the directory has certain workflow advantages:
Previously we tried using
-vto mount the directory but this didn't work very well:git resetbetween dependency updates.-v "$(pwd):/home/dependabot/dependabot-updater/repo:ro"The flag I chose for now is
--local, but if you have a better idea let me know. The terms "directory", "repo", "path" are overloaded already so it was difficult to find a new term.